View Issue Details

IDProjectCategoryView StatusLast Update
0000016KafkaEsqueImprovementpublic2018-12-05 19:01
ReporterOliver G.Assigned To 
PrioritynormalSeverityfeatureReproducibilityN/A
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in Version0.12.0 
Summary0000016: Dependency Injection with Guice (or Spring)
Description

(Spike :-) )
Analyse if you want to use a Dependency Injection Framework in KafkaEsque.
Consider checking Guice, maybe it is a good fit to JavaFX.

Simple sample containing a link to a short blog entry of the author
https://github.com/Pscheidl/JavaFX8DependencyInjection

Although German Wiki Page shows old version and some resources are from 2016, Guice seems to be alive and had a new version one month ago:
https://mvnrepository.com/artifact/com.google.inject/guice/4.2.2

When comparing to Spring, I recommend checking a number of aspects also listed in the following article, e.g. startup time, dependency size, compile time help:
https://dzone.com/articles/an-opinionless-comparison-of-spring-and-guice

TagsNo tags attached.

Activities

patschuh

patschuh

2018-11-30 17:29

developer   ~0000013

To make guice work, the controller reference in the fxml had to be removed.
If this causes problems or leads to excessive amounts of warnings and errors in IntelliJ or SceneBuilder in the future, guice will be removed again.

patschuh

patschuh

2018-12-03 07:29

developer   ~0000014

Looked over it again, will have to change the FXMLLoader initialization, then the Controller reference in the fxml should be able to stay

Related Changesets

KafkaEsque: master 70281c0b

2018-11-30 17:11:06

patschuh

Details Diff
[ESQUE-14, ESQUE-16]:added start timestamp option for trace key;
Reworked Consumer Handling;
Introduced Guice for evaluation
Affected Issues
0000014, 0000016

KafkaEsque: master 1cbabb6f

2018-12-05 19:00:02

patschuh

Details Diff
[ESQUE-16]: Add FXMLLoaderProvider; undo removal of controller in fxml
Affected Issues
0000016

Issue History

Date Modified Username Field Change
2018-11-29 22:18 Oliver G. New Issue
2018-11-30 17:11 patschuh Changeset attached => KafkaEsque master 70281c0b
2018-11-30 17:12 patschuh Assigned To => patschuh
2018-11-30 17:12 patschuh Status new => assigned
2018-11-30 17:29 patschuh Status assigned => resolved
2018-11-30 17:29 patschuh Resolution open => fixed
2018-11-30 17:29 patschuh Fixed in Version => 0.12.0
2018-11-30 17:29 patschuh Note Added: 0000013
2018-12-03 07:29 patschuh Status resolved => feedback
2018-12-03 07:29 patschuh Resolution fixed => reopened
2018-12-03 07:29 patschuh Note Added: 0000014
2018-12-03 07:30 patschuh Status feedback => assigned
2018-12-05 19:00 patschuh Changeset attached => KafkaEsque master 1cbabb6f
2018-12-05 19:01 patschuh Assigned To patschuh =>
2018-12-05 19:01 patschuh Status assigned => resolved
2018-12-05 19:01 patschuh Resolution reopened => fixed